forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from chromium:main #116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL extends the expiry date for the following histograms: - Signin.Extensions.GaiaRemoteConsentFlowResult by 3 months because we are planning to experiment with chrome.identity API soon - Signin.OAuth2MintToken.ApiCallResult by 6 months because this histogram is generally useful to monitor mint token API health Fixed: 1265522, 1277108 Change-Id: Iecab259099b20eda1d35042ad194a8709f1f050a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339971 Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/main@{#951865}
Fix DCHECK when scrolling through TableCellCatalogViewController. Change-Id: Ifce1ffdfdb5bb42fb1f0cb6675d7cb728fbf653c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338360 Reviewed-by: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951866}
We are in the process of moving all Autofill Assistant code to //components. For this we need to remove all dependencies on Chrome code. In the long term moving SharedPreferencesManager out of //chrome might be the best solution but due to time constraints we are removing our preferences from it for now. Bug: b/173103628 Change-Id: I25a5c8b4f89024832e2dcfdf63cac77cc9e11699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3317417 Auto-Submit: Florian Gauger <fga@google.com> Reviewed-by: Sandro Maggi <sandromaggi@google.com> Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Florian Gauger <fga@google.com> Cr-Commit-Position: refs/heads/main@{#951867}
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3772b4e1977a..56b07585df4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I304000452a46e28583054bf9efbe85bcd6a62037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340820 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951868}
You'd think that in a VStack of image and text, SwiftUI would support some way to signal that you want the image to control the width of the stack and the text to just flow after that. But I couldn't find a way, so this CL just calculates the width of the icon and fixes the width of the entire Destination view at that width. Fixed: 1279876 Change-Id: I31d96baeb3220947b360ebbb8ca9900491f063b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338528 Reviewed-by: David Jean <djean@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/main@{#951869}
Remove usage of std::function and replace it with raw function pointers, as std::function is banned by the Chromium C++ style guide. See also https://chromium.googlesource.com/chromium/src/+/main/styleguide/c++/c++11.md#function-objects Additionally remove the usage of base::NoDestructor as it "is not needed because the templated class has a trivial destructor". Bug: 1237044 Test: python3 generate_policy_source_test.py Test: components_unittests --gtest_filter=PolicyProtoDecodersTest.* Test: Check manually that the same policies set via YAPS still appear in chrome://policy Change-Id: I49804e69d3372d50bca59eecd6c51f6c4ee14216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3332720 Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Jana Grill <janagrill@google.com> Cr-Commit-Position: refs/heads/main@{#951870}
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ibfd38d2c6c7b47fb4cb6cfa2f2e2d2986d90167e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340823 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951871}
Most functions do not support empty arguments, but var() is an exception; we should support an empty fallback (ie., second argument). Fixing this is also a prerequisite for properly stripping spaces when parsing custom CSS properties (otherwise we would turn a valid case into an invalid case). R=andruud@chromium.org Bug: 1220148 Change-Id: Ie1aa875bdec91bc0f48b7fa47bae6c0ab9e35006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338993 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/main@{#951872}
Update "Screen lock" string (that is shown for devices without PIN login support) to "Lock screen" to make it consistent with "Lock screen and sign-in" string (that is shown for devices with PIN login support). Bug: 1152711 Change-Id: If83740dc1cc05c473549b12b9ff195ea4cf5ff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338339 Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/main@{#951873}
Bug: 1279285 Change-Id: Ic04665eeff7548f1cb0605b39af3a8b8741c5fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341312 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951874}
This CL expands the hardware video decoding sandbox warm-up with rules that were missed by CL:3280671: 1) We allow out-of-process video decoders to open the render node (/dev/dri/renderD*). This is needed to let CL:3316246 work because it uses a path that opens the render node for reading [1]. This is restricted to builds with VA-API (i.e., Intel and AMD). Note that this is also in the GPU presandbox hook ([2], [3], [4], [5], [6]), except that there, reading and writing is allowed. 2) We dlopen() libv4l2 depending on the USE_LIBV4L2 build flag (not USE_V4L2_CODEC). This is to be consistent with the GPU presandbox hook [7]. 3) We add a few AMD-specific rules that were taken from the existing GPU presandbox by trial and error ([8], [9], [10], [11], [12]). [1] https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/chromeos/platform_video_frame_utils.cc;l=116-117;drc=c9a3bec6c561e2a60757af4a8f765525e29c7f43 [2] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=375-382;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [3] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=221;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [4] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=257;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [5] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=209-210;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [6] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=193;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [7] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=493-494;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [8] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=539-546;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [9] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=205;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [10] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=234-240;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [11] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=193;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a [12] https://source.chromium.org/chromium/chromium/src/+/main:content/gpu/gpu_sandbox_hook_linux.cc;l=450-457;drc=96cbf5dfae36c13cfd464ef7035d7aa3a989b97a Bug: b:195769334 Test: arc.VideoDecodeAccel.h264_oopvd_vm on volteer with CL:3316832 Change-Id: I828e3ffbcb23c0ed74abc39fa252cf610aaab28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3328443 Reviewed-by: Matthew Denton <mpdenton@chromium.org> Auto-Submit: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/main@{#951875}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: Id1a641da70b0353f2808065323a76bd24e14a9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340815 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951876}
If ML service is not available on the device, we should report document scanning as unsupported. Bug: b:209726834 Test: Manually Change-Id: I35091481b476608f88e2fac405ef9169d1c25881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327823 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/main@{#951877}
These tests are failing on TSan due to a data race related to FeatureList. This CL attempts to fix the issue by initializing the test's ScopedFeatureList earlier, in the test fixture constructor instead of in SetUp(). Bug: 1278500 Change-Id: Id14dd86bf362e8c4f8f1de98dfc9a295dc1b02c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341532 Commit-Queue: Marc Treib <treib@chromium.org> Owners-Override: Marc Treib <treib@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/main@{#951878}
For WebRtcVideoFrameAdapter, the RenderableGpuMemoryBufferVideoFramePool is created on one thread and used on another. Bug: 1278262 Change-Id: I3d535284418cf12dad1b8489c8cbfc6428229986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3330362 Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/main@{#951879}
Using wpt-import in Chromium 0276eba. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-sizing futhark@chromium.org, andruud@chromium.org, ericwilligers@chromium.org, shend@chromium.org: external/wpt/css/css-conditional NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Id42e514070e7551cd146f00f3652b1332bdb5f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340752 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951880}
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I00df0f8fb53aa833cb18a84f77e4e91db0c1f6fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3321547 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#951881}
The new tests pass with no code changes. Bug: 1278262 Change-Id: I000f4b635068f704fe83fdcc0bda3ac43294065f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338659 Reviewed-by: ccameron chromium <ccameron@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Ben Wagner <benjaminwagner@google.com> Auto-Submit: Ben Wagner <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/main@{#951882}
Fixes the negative case of range adjustment of the conversion from v8::Value to int16_t. Bug: 1269182 Change-Id: I43d14fb60512665441c2c624685372511d3380b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3293443 Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/main@{#951883}
Add OWNERS files to Support Tool resource files as a follow-up to cl/3172793. Move support_tool* files under chrome/browser/ui/webui to their own dedicated folder. BUG=b:199691085 TEST-None. Change-Id: I08b30ae731fa31a86f89dd573b43ea0cb2344a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3338912 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Irem Uguz <iremuguz@google.com> Cr-Commit-Position: refs/heads/main@{#951884}
Doc: https://goo.gle/devtools-async-tasks Bug: chromium:1275875 Change-Id: I0e8c019bc0a7fd30afc55ee994c46083590efd30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3320456 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/main@{#951885}
Bug: b:172340451 Test: tsc compiles Change-Id: I3a16cb498892b5e36ce35c6cc954af54c6a77ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3299753 Reviewed-by: Shik Chen <shik@chromium.org> Commit-Queue: Pi-Hsun Shih <pihsun@chromium.org> Cr-Commit-Position: refs/heads/main@{#951886}
CL uses the existing auxiliary text functionality provided by the TreeView to expose the partitioned status of cookies within the CollectedCookiesViews. New functionality is added to the TreeView to support independently coloring the auxiliary text, and line-end padding is introduced to improve the view layout. Bug: 1279760 Change-Id: I44f46dc4c177c0559ecacfd4851ceb551183b27c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3307040 Reviewed-by: Mike Wasserman <msw@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/main@{#951887}
This patch fixes separator issue: https://screenshot.googleplex.com/8exAX9YE8uxyrzk Dark mode: before: https://drive.google.com/file/d/1XgVFxbu1R5NTl1pj-whQzqin37OhuokP/view?usp=sharing&resourcekey=0-4XAIKPp7gWGHMfJ6MLCwTg after: https://drive.google.com/file/d/1Ap9XqAKzq1M1q1AcFTnbypl9JqZOgVrW/view?usp=sharing&resourcekey=0-K6sWS7rWJU2O8c9D4jE7bA Light mode: before: https://drive.google.com/file/d/1J7Puy8knURtmGy9u9XAyIuJ8kK6kCX2T/view?usp=sharing&resourcekey=0---XGNqRbQ4CYIvlv1KVcwg after: https://drive.google.com/file/d/1BNJlRTWdBiLWvE6bzZ_wPUSOkfqaMwdx/view?usp=sharing&resourcekey=0-FYrWe93Z9HlpGcFdHNyo2A Fixed: 1261887 Change-Id: If37c571a7aaa50d2b947136caa3b85cce85686e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339313 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/main@{#951888}
…k-98.0.4758.7-r1 to 98-4744.1-1639397847-benchmark-98.0.4758.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iaca90e9732dbae4a0864ee66a9e9e819204e5d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341613 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951889}
The context menu should be displaying the full URL on more line to give more information to the user. Fixed: 1278734 Change-Id: I459a20b66ffaf80037a7039ad803b26de8e397de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341053 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Ewann Pellé <ewannpv@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951890}
Namely is_incognito_deprecated and restore_last_session_deprecated. They are unused (the information is encoded via initial_browser_action instead). Bug: chromium:1194304 Change-Id: Ia8f74d3eee6a4129782e09afaf41c2f093d3d968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3329856 Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951891}
Bug: 1279102 Change-Id: Ic3305f4778ad436124c41316950ba2563504a664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340935 Reviewed-by: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/main@{#951892}
…8.0.4758.7-r1 to 98-4744.1-1639393599-benchmark-98.0.4758.8-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I986cd13090609858325037ff5d0cdc3ba43b64f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341615 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951893}
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_nightly_202112150100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/jZ1wDChducDMF-MWFvXLkLZpk_AWan76x5hDRvEhqLoC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chrome.try:linux-chromeos-chrome Bug: b/206375321,b/210012141,b/210057761 Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: Ia5a46d789110e84c5def91580e907127dc49258d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341371 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951894}
Using wpt-import in Chromium dd7cb63. With Chromium commits locally applied on WPT: 6ed69eb "Migrate cookie-test.js's httpRedirectCookieTest to test_driver.delete_all_cookies" 7cd9af9 "Always assume that non-auto 'columns' might create a multicol." 004daf6 "[Sheriff] Undo 'standalone' for blocklisted-service-in-filter" 7b2fc96 "Allow empty CSS custom properties values." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Change-Id: Ib93dda5420f946756117761f5f21dc152089cc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341634 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951970}
This was necessary for extension logic in the function, which has since been removed. Bug: 1209417 Change-Id: I637943a8d8335346037b8bf5a727653deada7ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339383 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Charles Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/main@{#951971}
https://android.googlesource.com/platform/external/perfetto.git/+log/f9abf9948a18..22467673a50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I8eb1baf6cfb4bdce7d195b2d82b2326cd21cf824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342066 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951972}
Automatic update for 2021-12-15 UTC Change-Id: Ic38dc48111bc445fd0a6762b89e91b5c01f6b549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341095 Commit-Queue: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Bot-Commit: CT Log list updates bot <mdb.chrome-pki-metadata@google.com> Cr-Commit-Position: refs/heads/main@{#951973}
Bug: 212374 Change-Id: I0b14681d28438eaba7fc42743636f61e1b97cd45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3306459 Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Danil Somsikov <dsv@chromium.org> Cr-Commit-Position: refs/heads/main@{#951974}
With MPArch, the page url is supposed to be retrieved from RenderFrameHost->GetMainFrame(), rather than from its owning WebContents instance. Bug: 1277953 Change-Id: Ia129c4b194b2a6b1b10bf5770ca2a1439ea94351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3323032 Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Glen Robertson <glenrob@chromium.org> Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Claudio DeSouza <cdesouza@igalia.com> Cr-Commit-Position: refs/heads/main@{#951975}
This test disables the following tests that are flakily fail on Android M bots: - TabSuggestionMessageCardTest#groupTabSuggestionReviewedAndAccepted - TabSuggestionMessageCardTest#closeTabSuggestionReviewedAndDismissed Bug: 1273142, 1280257 Change-Id: I54f9aecc09879ba619d1cf7c09fd8855c8c19e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341555 Owners-Override: Alex Ilin <alexilin@google.com> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/main@{#951976}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Disable-Retries: true Change-Id: I47e0648d5e161393ac9680ffbe50d54c38cd1717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341773 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951977}
The test is still failing on Marshmallow 64 bit Tester. Bug: 1269017 Change-Id: Idcae10390805801afcba46e67cd6fec853c3aa90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3327867 Quick-Run: Henrique Nakashima <hnakashima@chromium.org> Auto-Submit: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by: Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/main@{#951978}
These experiments target <=M96 so can now be removed from the config at head. Fixed: 1232625 Change-Id: I8805578393c2f780b14493ca5fe60ef49b2a5546 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341318 Commit-Queue: Eric Seckler <eseckler@chromium.org> Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/main@{#951979}
It was disabled for flake on the sanitizer bots. Re-enable it on other bots. Do some incidental cleanup. Delete the test OpenBrowserUsingContextMenu. This test provides little additional value now that we're running the shelf item test. Bug: 1038342 Test: browser_tests Change-Id: I20850bf1d26d09ecf0ff391898f90190bc3b34b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341384 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/main@{#951980}
This test has started frequently failing following the landing of https://chromium-review.googlesource.com/c/chromium/src/+/3329602/. That CL is not suitable for immediate revert as it was landed on trunk, 98, and 97 to investigate whether the behavior that it is undoing was the cause of a significant startup performance regression. I am investigating the reason for the increased flake of this test, but in the meantime, this CL disables it to avoid the flake causing problems for others. Bug: 1280192 Change-Id: I69bf1346f516abb54c901955fab156306d0a3910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341464 Reviewed-by: Alex Ilin <alexilin@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/main@{#951981}
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b47975a82916..d692cac31ffe 2021-12-15 aerotwist@chromium.org Remove patchColorText usage in NetworkWaterfallColumn 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/timeline/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/settings/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/elements/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class members in panels/network/components/ 2021-12-15 tvanderlippe@chromium.org Migrate to private class fields in panels/issues/components/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:1222126,chromium:1278738 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iee6b9f009eebca09b56666aa866553978aa00066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341413 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951982}
Preparation for being able to do palette string to index resolutions required for font-palette and @font-palette-values support. Bug: 1170794 Change-Id: I43eaeed78ed37f1ef18f7c6f5d58a1e291042617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340943 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#951983}
Bug: 1279835 Change-Id: I67e72c8871338e7b025089bfab0a88602a7917dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341179 Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/main@{#951984}
Chrome-wide audio mixing: When the last listener is gone but there are active tracks, the switch to unmixed playback is scheduled. Meanwhile, all tracks may be gone. In that case we want to stop mixing immediately. (Otherwise next track to come may be started as a mixed playback for no good reason, and then switched to unmixed playback shortly after when the timer runs out, - which would cause an unnecessary glitch.) Bug: 1279802, 1224845 Change-Id: Ic524492a528e6feb611970de6642a5c31bc674e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341322 Reviewed-by: Sam Zackrisson <saza@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/main@{#951985}
NGInlineItemsBuilderTemplate::ExitInline() has a special rule for AREA elements, and we need to respond on that during pre-paint, so that they are visited (and get their invalidation flags cleared). Note that this doesn't fix the original fuzzer in crbug.com/1279525 Bug: 1279525 Change-Id: Ib05b4cc3eebff85fc5e2999b1f90d16d75bf36f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341320 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#951986}
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7f13e5c5ff2d..1cad40c1e720 2021-12-15 cmfcmf@chromium.org dependency: convert docstring types to typing hints 2021-12-15 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-15 cmfcmf@chromium.org payload: convert docstring types to typing hints 2021-12-15 chrome-bot@chromium.org Automated Commit: Updated config generated by config-updater builder. 2021-12-15 yoshiki@google.com Collect goma logs on failure of BuildPackage 2021-12-15 yueherngl@google.com brya: enable hw_tests 2021-12-15 kimjae@chromium.org gs: google storage Stat() retry throws GSNoSuchKey 2021-12-15 shaochuan@chromium.org android: implement WriteLKGB endpoint 2021-12-15 shaochuan@chromium.org api: sync protos 2021-12-15 shaochuan@chromium.org android: canonical way to retrieve Android package dir 2021-12-15 rickytlchang@google.com draco: add factory/recovery signing and disable HW test 2021-12-14 vapier@chromium.org cros ap: add framework for registering subcommands 2021-12-14 cmfcmf@chromium.org sdk: convert docstring types to typing hints 2021-12-14 zland@google.com lib: Remove COIL terms from perf_uploader & refs 2021-12-14 zland@google.com lib: Remove COIL terms from uri_lib and references 2021-12-14 zland@google.com Remove COIL terms from osutils and references 2021-12-14 vapier@chromium.org cros uprevchrome: drop deprecated command 2021-12-14 vapier@chromium.org change ~/trunk to ~/chromiumos 2021-12-14 juahurta@google.com config: Disable unittests on skyrim-release 2021-12-14 latware@google.com Enabling build of callbox server. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I2d557fbc482dca2530887594441de62295ce0926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3342086 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951987}
Iif AutofillDelayPopupControllerDeletion is enabled, AutofillPopupControllerImpl deletes itself in a separate task. Before this CL, to cancel a pending deletion in GetOrCreate(), we invalidated the WeakPtrs. This also included WeakPtrs in AutofillPopupViewNativeViews which should not have been invalidated. Instead of invalidating WeakPtrs, this CL cancels the deletion task. Bug: 1280027, 1279971, 1280009 Change-Id: Ibdcc73cc392bb00732f72ac592c88e8940866b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3340941 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#951988}
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202112150600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/27KUeowb-avScJevs9PyckybR1s34lIOg_CMEaolREQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Ibc79e3e1d9a4ea21b576a71d4021abb48653eebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341777 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951989}
When calculated AXSelectedChildren, AXSelected was not respected on the child for the non-multiselect case. This fix ensures the child is selected before returning it, which successfully keeps "selected" from being voiced by VoiceOver when navigating to a button. Bug: 1276763 Change-Id: I4c52e56a7170c940ee06e4bf1cd8bb8c63244f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3335616 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Valerie Young <spectranaut@igalia.com> Cr-Commit-Position: refs/heads/main@{#951990}
The fuzzer found a null-dereference error in Element::Blur that was introduced by one of my change a while back. This CL fixes it. Bug: 1278752 Change-Id: I0eb0930c5cc2c4ea2f8350d5f873f86bc593ab01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3339916 Reviewed-by: Daniel Libby <dlibby@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/main@{#951991}
The enum name was used instead of the histogram name. Bug: 1280309 Change-Id: Ia4fccf40393abfccd4c852af98f05a2633c2c8fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341524 Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by: Viktor Semeniuk <vsemeniuk@google.com> Commit-Queue: Elizabeth Popova <lizapopova@google.com> Cr-Commit-Position: refs/heads/main@{#951992}
This removes nonsfi support from NaCl's chrome IPC. Also, it removes nonsfi flag from NexeLoadManager. BUG=b/200965779,1273132 TEST=Ran tryjob. Change-Id: I5bc9376ccf270dbe5d86cf8884a9c0dccef25b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341092 Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by: Derek Schuff <dschuff@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951993}
The test `external/wpt/referrer-policy/gen/srcdoc.meta/strict-origin/iframe-tag.http.html` started failing on Mac a short while ago. Of course it passes for me locally, and I have no good ideas as to how to fix this, so I'm going to start by re-enabling to see if I can reproduce it that way. R=hiroshige@chromium.org Bug: 1264753 Change-Id: Ib93719803a7c2131794d50d6cd55816f80d1fba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341636 Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/main@{#951994}
This change adds logic to HostResolverManager to use pre-configured IP addresses for the initial connection to a DoH server. If a bootstrap IP is used, the resolver also starts an asynchronous followup request to ask the DoH server for its own IP address, which will be used for subsequent connections. This change does not add the ability to store any bootstrap IPs, so this logic is not yet live. Bug: 1200908 Change-Id: Iab4bf7344b59e042a9bdaa944ec5ac7c1ff2f35f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3193799 Reviewed-by: Eric Orth <ericorth@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/main@{#951995}
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/androidx-chromium Please CC mheikal@google.com,clank-library-failures@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel Tbr: mheikal@google.com,clank-library-failures@google.com Change-Id: I24540b55e0e6b772f2acb7dfade57c9199cf6321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341771 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#951996}
(xcode13 requires Mac OS 11) Bug: b/210105045 Change-Id: I5f45432254babd653ecd25332c51a1c766cdb51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3341551 Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> Auto-Submit: Björn Terelius <terelius@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#951997}
pull bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
…ommits) https://chromium.googlesource.com/external/github.com/freetype/freetype2-testing.git/+log/fe2eddae6176..1ca0c99d25ae $ git log fe2eddae6..1ca0c99d2 --date=short --no-merges --format='%ad %ae %s' 2022-05-23 drott Track VisitedSet at top level before colrv1_start_glyph (#127) 2022-01-11 bungeman Unquote cc and cxx when executing. (#126) 2022-01-09 bungeman Quote more strings. (#125) 2022-01-09 bungeman Build bzip2 correctly. (#124) 2022-01-06 bungeman Use CC and CXX, check for clang version. (#123) 2022-01-06 bungeman Allow ubsan with asan or by itself. (#122) 2021-12-29 bungeman Remove CMAKE_x_COMPILER from libcxx build. (#119) 2021-12-24 bungeman Drop support for git <= 2.14. (#112) 2021-12-24 bungeman Make --rebuild work correctly again. (#111) 2021-12-24 bungeman Use sanitize-coverage=0 not no-sanitize-coverage (#115) 2021-12-24 bungeman Choose exactly one of the exclusive fuzzers (#117) 2021-12-24 bungeman Add missing quotes to libcxx.sh (#116) 2021-12-18 bungeman Add trace-pc-guard to no-sanitize-coverage. (#114) 2021-12-16 bungeman Add llvm-project for MemorySanitizer build. (#113) 2021-12-10 bungeman Add MemorySanitizer build option. (#110) 2021-11-09 drott Update corpus files for COLRv1 again (#109) 2021-11-01 drott Update corpus files for COLRv1 (#108) Created with: roll-dep src/third_party/freetype-testing/src Change-Id: I358febbaa1933d6d56ad655f62702d67e4a6c0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3777978 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/main@{#1026318}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )